improve x11 startup times #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related issue: wez#5802 requesting `GetScreenResourcesCurrent` instead of `GetScreenResources` brings startup times down from 1.5 seconds to 30 microseconds on my machine (measured with dumb printlns). according to some findings `GetScreenResourcesCurrent` may return nothing, so i kept `GetScreenResources` there as a fallback, just in case, although I'm not 100% sure that it's necessary. see: - https://github.com/qt/qtbase/blob/c234700c836777d08db6229fdc997cc7c99e45fb/src/plugins/platforms/xcb/qxcbscreen.cpp#L963 - https://github.com/qt/qtbase/blob/c234700c836777d08db6229fdc997cc7c99e45fb/src/plugins/platforms/xcb/qxcbconnection_screens.cpp#L390 also worth to note that i3 does not rely on `xcb_randr_get_screen_resources`, but only on `xcb_randr_get_screen_resources_current`, see: - https://github.com/search?q=repo%3Ai3%2Fi3%20get_screen_resources&type=code
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #5802
requesting
GetScreenResourcesCurrentinstead ofGetScreenResourcesbrings startup times down from 1.5 seconds to 30 microseconds on my machine (measured with dumb printlns).according to some findings
GetScreenResourcesCurrentmay return nothing, so i keptGetScreenResourcesthere as a fallback, just in case, although I'm not 100% sure that it's necessary. see:also worth to note that i3 does not rely on
xcb_randr_get_screen_resources, but only onxcb_randr_get_screen_resources_current, see: